-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: memory server #601
feat: memory server #601
Conversation
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
I love this more refined approach to the same simple file based idea. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
* origin/v1.0: feat: add a truncating agent (#579) feat: Release devtools opening keyboard shortcut when goose window is not focused (#614) feat: performance tweaks for partial release (#611) Alexhancock/inline code (#612) feat: add more tracing logs, trim loaded prompt (#603) feature: new welcome page and real keychain (#604) fix: model names in UI API key warning (#609) feat: map non-ok responses from provider to human readable error msgs (#610) fix: update BufReader capacity to 2MB (#605) fix: escape double quotes in error part (#602) refactor: remove unused errors in mcp-client (#598) add more context from mcp server errors (#599) fix: error formatting for vercel data format (#597) feat: Add endpoint to store secrets in keychain (#595)
crates/goose-mcp/src/memory/mod.rs
Outdated
|
||
let data = args["data"] | ||
.as_str() | ||
.ok_or_else(|| io::Error::new(io::ErrorKind::InvalidInput, "Data must be a string"))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this fails for retrieve_memories
which doesn't have a 'data' property in the JSON schema
the fix was easy - needed to make data field optional. i put the changes here if you wanna merge to this branch - #629 i'm not sure why the Inspector tool did not catch this. i think it'd be good to test this out more thoroughly via
|
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
tested memory on a few more examples, it seems to work as expected. I think generally if we want to improve the usage of memory tool, we could consider reducing friction in the tool use by removing category and global arguments. |
Brings forward memory server.
Example Usage:
Notes